Skip to content

Move ConsistentImplodeRector from php80 to php74 - #8894

Merged
samsonasik merged 1 commit into
rectorphp:mainfrom
zoliszabo:pr/01
Nov 2, 2026
Merged

samsonasik merged 1 commit into
rectorphp:mainfrom
zoliszabo:pr/01

Conversation

@zoliszabo

Copy link
Copy Markdown
Contributor

Passing the separator after the array (i.e. using the legacy signature) has been deprecated since PHP 7.4.

@samsonasik

Copy link
Copy Markdown
Member

Let's close - reopen to see if Github PR list will show up ...

@samsonasik samsonasik closed this Nov 2, 2026
@samsonasik samsonasik reopened this Nov 2, 2026
@samsonasik

Copy link
Copy Markdown
Member

you also may need to rebase latest main, that's may needed to ensure all green

Passing the separator after the array (i.e. using the legacy signature) has been deprecated since PHP 7.4.
@zoliszabo

Copy link
Copy Markdown
Contributor Author

you also may need to rebase latest main, that's may needed to ensure all green

Did the rebase.

@samsonasik
samsonasik merged commit 2a02e37 into rectorphp:main Nov 2, 2026
51 checks passed
@samsonasik

Copy link
Copy Markdown
Member

Thank you @zoliszabo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants